-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Fix comment on LeaderElectionResourceLock #1903
📖 Fix comment on LeaderElectionResourceLock #1903
Conversation
d37c876
to
dc1eca0
Compare
6767dff
to
d5f6161
Compare
@camilamacedo86 Hey, would you please take a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shows for me 🥇
Just a nit.
If possible would be nice if we also describe the bad side effects in case someone does not follows the guidance. Otherwise, it is:
/approved
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
d5f6161
to
e4e13b9
Compare
@camilamacedo86 Could you approve this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approved
@FillZpp I have permissions to lgtm only. We will need a second reviewer here to add the approved label. |
Okey. @alvaroaleman Could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, camilamacedo86, FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-controller-runtime-test-master |
Signed-off-by: FillZpp FillZpp.pub@gmail.com
Fix comment on LeaderElectionResourceLock